Skip to content
Snippets Groups Projects
Commit 250d9b56 authored by LouisGendron's avatar LouisGendron
Browse files

Add staff user to profiles that can modify a DS

parent a1dadf63
No related branches found
No related tags found
1 merge request!98Resolve "Allow staff user to modify any DS"
...@@ -280,7 +280,7 @@ class DataSetForm(forms.ModelForm): ...@@ -280,7 +280,7 @@ class DataSetForm(forms.ModelForm):
is_valid = super().is_valid() is_valid = super().is_valid()
if not is_valid: if not is_valid:
return is_valid return is_valid
elif self.instance.id: # Apply only to DS update elif self.instance.id and self.request_profile: # Apply only to DS update
is_valid = self.instance in DataSet.objects.writable_by_profile(self.request_profile) is_valid = self.instance in DataSet.objects.writable_by_profile(self.request_profile)
return is_valid return is_valid
......
...@@ -307,16 +307,18 @@ class DataSetManager(models.Manager): ...@@ -307,16 +307,18 @@ class DataSetManager(models.Manager):
Created by user Created by user
OR accessible by user AND NOT read-only OR accessible by user AND NOT read-only
""" """
return super().get_queryset().filter( if profile.user.is_staff:
Q(created_by=profile) qs = super().get_queryset()
| ( else:
( qs = Q(created_by=profile) \
Q(share_profiles=profile) | (
| Q(share_labs__members=profile) (
| Q(share_groups__profiles=profile) Q(share_profiles=profile)
) & Q(read_only=False) | Q(share_labs__members=profile)
) | Q(share_groups__profiles=profile)
) ) & Q(read_only=False)
)
return qs
class DataSet(models.Model): class DataSet(models.Model):
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment